Skip to content

fix: clarify requirements#5

Merged
tholok97 merged 1 commit intomainfrom
clarify-req
Mar 18, 2026
Merged

fix: clarify requirements#5
tholok97 merged 1 commit intomainfrom
clarify-req

Conversation

@tholok97
Copy link
Copy Markdown
Collaborator

@tholok97 tholok97 commented Mar 17, 2026

Reviewed internally.

Commit message:

fix: clarify requirements

A requirement like >=6.33.2 includes >=7.0.0. This was not the intention.
Clarify by limiting upper versions to original intention.

Also declare script dependencies for versions, making them runnable outside the 
context of this repository, and removing pillow as a dev dependency for the 
project. To run the examples with a locally edited version of wlsonar, we can
do: 

    uv run --with-editable . examples/convert_recording.py

@tholok97 tholok97 force-pushed the clarify-req branch 3 times, most recently from 8ee74c6 to 6dadf12 Compare March 17, 2026 14:58
@tholok97 tholok97 self-assigned this Mar 17, 2026
@tholok97 tholok97 requested a review from wlkh March 17, 2026 14:59
A requirement like >=6.33.2 includes >=7.0.0. This was not the intention.
Clarify by limiting upper versions to original intention.

Also declare script dependencies for versions, making them runnable outside the
context of this repository, and removing pillow as a dev dependency for the
project. To run the examples with a locally edited version of wlsonar, we can
do:

    uv run --with-editable . examples/convert_recording.py
@tholok97 tholok97 merged commit 6fdf3c2 into main Mar 18, 2026
15 checks passed
@tholok97 tholok97 deleted the clarify-req branch March 18, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants